Fix error generation for missing pgf.texsystem. #26689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Sep 4, 2023
| ) from err | ||
| except OSError as err: | ||
| raise RuntimeError( | ||
| f"Error starting process {self.latex.args[0]!r}") from err |
There was a problem hiding this comment.
Does this work? AFAICS, if the try block raises self.latex is not set in this method, i.e. it will be whatever it was before, possibly None?!?
There was a problem hiding this comment.
Oops, there was the same bug there as with the FileNotFoundError case; fixed it too.
If pgf.texsystem isn't installed, then self.latex will not be created *at all* by _setup_latex_process, and we thus cannot access self.latex.args[0], but must instead read the rc value again. To make this clearer, move the error handling into _setup_latex_process, instead of having it outside. No test because that'd require setting up a test env where pgf.texsystem is explicitly *missing* (or go through lots of mocks), which seems not worth it.
timhoffm
approved these changes
Sep 4, 2023
ksunden
approved these changes
Sep 4, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 4, 2023
oscargus
added a commit
that referenced
this pull request
Sep 5, 2023
…689-on-v3.8.x Backport PR #26689 on branch v3.8.x (Fix error generation for missing pgf.texsystem.)
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Feb 14, 2024
Fix error generation for missing pgf.texsystem. (cherry picked from commit 5f785e3)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If pgf.texsystem isn't installed, then self.latex will not be created at all by _setup_latex_process, and we thus cannot access self.latex.args[0], but must instead read the rc value again. To make this clearer, move the error handling into _setup_latex_process, instead of having it outside.
No test because that'd require setting up a test env where pgf.texsystem is explicitly missing (or go through lots of mocks), which seems not worth it.
This is (I think) the origin of the AttributeError in #26551.
PR summary
PR checklist