-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Small fixes found by velin #26705
Conversation
image to. | ||
hsv_max_sat : number, default: 0 | ||
The maximum saturation value that the *intensity* map can shift the output | ||
image to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know enough about HSV saturation, but it seems a bit "weird" that the min value is larger than the max value...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does seem odd, but the blend_hsv
function docstring below says:
The default extremes are
chose so that completely shaded points are nearly black (s = 1, v = 0)
and completely illuminated points are nearly white (s = 0, v = 1).
So, I think this is expected although unintuitive at first glance.
image to. | ||
hsv_max_sat : number, default: 0 | ||
The maximum saturation value that the *intensity* map can shift the output | ||
image to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does seem odd, but the blend_hsv
function docstring below says:
The default extremes are
chose so that completely shaded points are nearly black (s = 1, v = 0)
and completely illuminated points are nearly white (s = 0, v = 1).
So, I think this is expected although unintuitive at first glance.
…705-on-v3.8.x Backport PR #26705 on branch v3.8.x ([Doc] Small fixes found by velin)
PR summary
PR checklist