Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin NumPy below v2 for 3.7.x #26706

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Pin NumPy below v2 for 3.7.x #26706

merged 1 commit into from
Sep 6, 2023

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Sep 6, 2023

PR summary

Pre-emptively pinning away from the major API break for the last bugfix release of the 3.7.x series.

PR checklist

@QuLogic QuLogic added the PR: dependencies Pull requests that update a dependency file label Sep 6, 2023
@QuLogic QuLogic added this to the v3.7.3 milestone Sep 6, 2023
@timhoffm
Copy link
Member

timhoffm commented Sep 6, 2023

Failed test is a subprocess timeout and unrelated to numpy pinning.

Note that this is not a full protection against getting broken environments because earlier matplotlib versions are unpinnend, and the solver may choose to downgrade to matplotlib 3.7.2 to be able to use numpy=2. Anyway, pinning now is better than not doing anything.

@timhoffm timhoffm merged commit e2a3029 into matplotlib:v3.7.x Sep 6, 2023
30 of 32 checks passed
@QuLogic QuLogic deleted the pin-numpy branch September 6, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants