Ensure GIL while releasing buffer #27290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
Nov 8, 2023
tacaswell
added
the
Release critical
tacaswell
approved these changes
Nov 9, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 9, 2023
tacaswell
added a commit
that referenced
this pull request
Nov 9, 2023
…290-on-v3.8.x Backport PR #27290 on branch v3.8.x (Ensure GIL while releasing buffer)
|
@meeseeksdev backport to v3.7.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 15, 2023
QuLogic
added a commit
that referenced
this pull request
Nov 17, 2023
…290-on-v3.7.x Backport PR #27290 on branch v3.7.x (Ensure GIL while releasing buffer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This ensures the GIL is held while freeing the renderer buffer.
Fixes #27262
This became problematic in 3.12, but was likely possible in earlier python versions.
This method is handed to Obj-C code to call upon releasing, which we therefore do not fully control.
PR checklist