Fix draggable annotations on subfigures. #27343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ax = getattr(a, 'axes', None)
would return the SubFigure.axes list whena
is a subfigure, so the axes identity test would just be completely wrong. Fix that by special-casing subfigures. (Ideally I would entirely remove the axes equality test because that also breaks in the case of overlapping axes, but that's a much bigger change.)ref_artist.figure._canvas_callbacks
would fail when the ref_artist is on a subfigure because subfigures don't have a _canvas_callbacks attribute; instead useref_artist.figure.canvas.callbacks
where accessing the canvas attribute correctly goes back to the toplevel figure first.See test for an example (which would previously fail with an AttributeError).
PR summary
PR checklist