Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: install German language packs on ubuntu test runners #27581

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

tacaswell
Copy link
Member

Increase coverage of locale tests.

This will hopefully make coverage on the tests less noisy by reducing the chance we skip this test.

@tacaswell
Copy link
Member Author

The relevant section of code now reports 5 hits in codecov.

@dstansby dstansby merged commit 4df729a into matplotlib:main Dec 29, 2023
38 of 39 checks passed
@tacaswell tacaswell deleted the ci/de_locale branch January 3, 2024 19:53
@tacaswell
Copy link
Member Author

@meeseeksmachine please backport to v3.8.x

@tacaswell
Copy link
Member Author

@meeseeksdev please backport to v3.8.x

Copy link

lumberbot-app bot commented Jan 17, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.8.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 4df729a4755a4de6af706f069e23b1b3cdeab839
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #27581: CI: install German lanugage packs an ubuntu test runners'
  1. Push to a named branch:
git push YOURFORK v3.8.x:auto-backport-of-pr-27581-on-v3.8.x
  1. Create a PR against branch v3.8.x, I would have named this PR:

"Backport PR #27581 on branch v3.8.x (CI: install German lanugage packs an ubuntu test runners)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Jan 17, 2024
…untu test runners

Merge pull request matplotlib#27581 from tacaswell/ci/de_locale

CI: install German lanugage packs an ubuntu test runners
(cherry picked from commit 4df729a)
@tacaswell tacaswell modified the milestones: v3.9.0, v3.8.3 Jan 17, 2024
@QuLogic QuLogic changed the title CI: install German lanugage packs an ubuntu test runners CI: install German language packs an ubuntu test runners Jan 18, 2024
@QuLogic QuLogic changed the title CI: install German language packs an ubuntu test runners CI: install German language packs on ubuntu test runners Jan 18, 2024
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 21, 2024
…r-27581-on-v3.8.x

Backport PR matplotlib#27581: CI: install German language packs on ubuntu test …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants