Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement macos AppDelegate #27670

Merged
merged 1 commit into from Jan 22, 2024
Merged

Conversation

greglucas
Copy link
Contributor

PR summary

This suppresses a warning that appears with MacOS 14+. WARNING: Secure coding is not enabled for restorable state!

Thanks, @QuLogic and @tacaswell for the pointers on what needed to be done!

Testing: It seems like Python compiled with clang 15+ doesn't produce this warning, but installing Python 3.12 downloaded from python.org uses clang 13 and I do get the warnings locally.
Running a simple script you should see the warnings on main and then they should go away on this branch.

import matplotlib.pyplot as plt
plt.plot([1, 2, 3])
plt.show()

closes #27389

PR checklist

This suppresses a warning that appears with MacOS 14+.
WARNING: Secure coding is not enabled for restorable state!
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to make sense from a code point of view. Maybe @dstansby could test it?

@tacaswell
Copy link
Member

Merging on strength of: #27389 (comment)

@tacaswell tacaswell merged commit 1448ba8 into matplotlib:main Jan 22, 2024
45 of 46 checks passed
@tacaswell
Copy link
Member

Thanks @greglucas !

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 22, 2024
@greglucas greglucas deleted the macos-app-delegate branch January 22, 2024 17:29
rcomer added a commit that referenced this pull request Jan 22, 2024
…670-on-v3.8.x

Backport PR #27670 on branch v3.8.x (Implement macos AppDelegate)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants