Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: fix labeller #27694

Merged
merged 1 commit into from
Jan 25, 2024
Merged

MNT: fix labeller #27694

merged 1 commit into from
Jan 25, 2024

Conversation

story645
Copy link
Member

@story645 story645 commented Jan 24, 2024

PR summary

According to the error message and the labeler docs, I think this was a typo.

eta: also I think running into actions/labeler#628 and not sure if the fix is it needs to be fixed here and that'll fix it or combined w/ a checkout option.

@ksunden
Copy link
Member

ksunden commented Jan 24, 2024

Comment regarding typo, for reference:

#27689 (comment)

However, I'd like to hear from @QuLogic as to whether the lack of checkout is intentional or not.

@story645
Copy link
Member Author

#27689 (comment)

🤦‍♀️ knew I saw that somewhere

@story645
Copy link
Member Author

And for checkout, maybe has to do w/ https://github.com/actions/labeler#notes-regarding-pull_request_target-event

@QuLogic
Copy link
Member

QuLogic commented Jan 24, 2024

I think you were looking at old docs (and the referenced issue is older than v5); the v5 ones don't mention needing a checkout. In fact, the docs say it will read from the source repo (which it has been doing all this time). And I don't think it would have any effect, as pull_request_target will clone from the main repo, not the fork. That does unfortunately lead to the "can't test beforehand" issue.

So the changes to the workflow appear superfluous, as they are just setting configuration to the defaults and adding a checkout that doesn't do anything.

@story645
Copy link
Member Author

. In fact, the docs say it will read from the source repo (which it has been doing all this time).

I was just confused why it was still getting that error message, but just undid those changes.

@QuLogic QuLogic added this to the v3.9.0 milestone Jan 25, 2024
@QuLogic QuLogic merged commit ff0497c into matplotlib:main Jan 25, 2024
5 of 6 checks passed
@story645 story645 deleted the labeler branch January 25, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants