Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hist accepts dictionary views as label #27970

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fxjung
Copy link

@fxjung fxjung commented Mar 23, 2024

PR summary

Closes #27954.

PR checklist

@fxjung fxjung changed the title added test hist accepts dictionary views as label Mar 23, 2024
@fxjung fxjung changed the title hist accepts dictionary views as label hist accepts dictionary views as label Mar 23, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@tacaswell
Copy link
Member

As this appears to already be implemented on the main branch, it opens the question of if we fixed this intentionally or by accident. If we fixed it intentionally, we should verify that there is a test if we fixed it on accident we should definitely add a test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH]: Iterables in grouped histogram labels
2 participants