Add warning for multiple pyplot.figure calls with same ID #27992
+23
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Apr 3, 2024
tacaswell
reviewed
May 8, 2024
| def test_multiple_same_figure_calls(): | ||
| with pytest.warns(UserWarning, match="Ignoring specified arguments in this call"): | ||
| fig = mpl.pyplot.figure(1, figsize=(1, 2)) | ||
| fig = mpl.pyplot.figure(1, figsize=(3, 4)) |
There was a problem hiding this comment.
Suggested change
| fig = mpl.pyplot.figure(1, figsize=(3, 4)) | |
| fig2 = mpl.pyplot.figure(1, figsize=(3, 4)) | |
| assert fig2 is fig | |
| fig3 = mpl.pyplot.figure(1) | |
| assert fig3 is fig |
Do we have a test that it does not warn when re-accessed without parameters else where? It can not hurt to test here too even if we do.
There was a problem hiding this comment.
and it might be better to move the first fig invocation out of the context manager? 50/50 on that though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #27978. This hopefully adds the relevant warning discussed in the issue
PR checklist