New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] image based search (GSOC) #28009
base: main
Are you sure you want to change the base?
Conversation
Can you please |
There are a bunch of extraneous (or just incomplete) files in this PR. For example, the zip file seems to be empty (and I would be highly against including such a file in an MR), along with the javascript file. The recommendations file seems to be a huge file of possible recommendations, which does not seem to be maintainable or verifiable. |
@WeatherGod this PR started as part of a GSOC application for a visual search/detexify extension to the documentation build, but it looks likely that if we do this as GSOC this year it'll be a joint mentorship with sphinx-gallery and the code/PRs will likely go there. It'd likely be built off of/jumping off sphinx-gallery/sphinx-gallery#1125 Whether we want to enable that feature is a separate issue, but I think those pages can get created on build (like sphinx tags) and therefore don't need to be committed to the repo. Basically yes I agree w/ you that this PR is unlikely to go in, but wanted to try and give you some more context on what's going on. |
I'm really sorry a lot of the files were mostly for test runs and i didn't organize them properly yet. I'll add more documentation and try to explain what i did in a short summary here within tonight. Really sorry for the unorganized mess |
That's fine, but can you do your test run on your fork and just send me a link to the fork/update your application w/ it rather than opening up a pull request here since this is so experimental and if it gets accepted will likely live under sphinx-gallery. ETA: which our general practice for these things is that if it's not quite ready for a PR, to instead link folks to the branch on the fork. |
Understood. In that case, is the preferred communication channel gitter or should i email?
I checked the portal at gsoc and they wont allow updating the proposal anymore. the submission deadline is over. But I'll update my fork with new test runs and documentation and send you link over your preferred medium. |
gitter is fine. |
I had accidentally added these files that are generated at built time into the PR. I have modified the gitignore to not include auto generated files. I have tried updating the PR with cleaner code and more explanation. But note that, everything is still relevant only in the sense of a proof of concept / test run. In short the process is like this,
Some modifications that i have in mind and will be adding to the test run gradually
|
PR summary
This PR is mainly meant to be as a reference point for a test run i did for the GSOC proposal of implementing image based search on matplotlib docs.
I have tried updating the PR with cleaner code and more explanation. But note that, everything is still relevant only in the sense of a proof of concept / test run.
In short the process is like this,
gen_gallery.py
from sphinx-gallery iterates through example files, to replicate the same behavior)thumbnail_id
to each of them for uniquely identifying each. these thumbnails are stored in/image_search/index.recommendations
file._static/data.json
along with thethumbnail_id
of the image/example this vector representsgalleries/image_search/index.rst
contains the layout of the image search page and this page includes all generated thumbnails fromindex.recommendations
but all the thumbnails are kept hidden through a css rule_static/image_search.js
controls the search logic._static/data.json
sphx-glr-imgsearchresult-container
div.Currently tested integrations,
Some modifications that i have in mind and will be adding to the test run gradually
PR checklist