Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve MaxNLocator IndexError when no large steps #28292

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

ddeibert-nso
Copy link
Contributor

PR summary

Resolves IndexError in MaxNLocator._raw_ticks().

The IndexError occurred under the following conditions:

  • nbins=1
  • rcParams['axes.autolimit_mode'] == 'round_numbers'
  • the input parameters for vmin and vmax resulted in no large_steps (all are False)

closes #27603

PR checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@ddeibert-nso
Copy link
Contributor Author

I think a second approval is required before this PR can be merged. I don't think anything is needed from me to proceed. If there is, please let me know.

@tacaswell tacaswell added this to the v3.9.1 milestone Jun 2, 2024
@tacaswell tacaswell merged commit 0ab5567 into matplotlib:main Jun 2, 2024
41 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 2, 2024
@tacaswell
Copy link
Member

Thank you for your work @ddeibert-nso and congratulations 🎉 on your first merged PR to Matplotlib.

I hope we hear from you again!

timhoffm added a commit that referenced this pull request Jun 2, 2024
…292-on-v3.9.x

Backport PR #28292 on branch v3.9.x (Resolve MaxNLocator IndexError when no large steps)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

[Bug]: _raw_ticker() istep
3 participants