New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2897 Adding tests for pie ccw. Issue 2897 #2933
Conversation
Why did you delete this? We probably only need to test the non-default case as the existing tests cover the default case. |
Sorry. I will make another pull request. I believed this was the wrong branch and acted fast. Too fast I guess. |
I reopened it for you. Don't worry too much about making mistakes. We are all pretty friendly/understanding here and unless it is merged into master it won't hurt anyone. |
You shouldn't be removing the line width test files... |
About removing the line width test files - we should not remove them in this pull request or we should not do that at all? I imagined that the png test would be enough and that the pdf / svg tests were superfluous and we could do without them. I have only removed the pdf / svg files. The png are still there. |
Ah, sorry I didn't read carefully enough. I missed that it was just the not-png images. Sorry for the noise. |
Cool! |
closes #2897 Adding tests for pie ccw. Issue 2897
Merged. Thank you @sfroid ! |
Yayy... second contribution! Thanks for the help @tacaswell |
No description provided.