Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-Generate legend, through apply_callback/Apply #2947

Merged
merged 6 commits into from May 2, 2014
Merged

Re-Generate legend, through apply_callback/Apply #2947

merged 6 commits into from May 2, 2014

Commits on Apr 2, 2014

  1. Re-Generate legend, through apply_callback/Apply 

    If there is a legend, it is re-generated when "Apply" is clicked.
See Issue #2934:
Might have side effects.
#2934
tacaswell: "However this will clobber any legend that is not the auto-magically generated one so it should probably also get a tick box to enable/disable the updating of the legend."
Tick box not included.
    anykraus committed Apr 2, 2014
    Copy the full SHA
    0bc4c52 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2014

  1. Added a checkbox for (re-)generating auto-legend 

    Checkbox added that controls if an automatic legend is re-generated, or generated for the first time.
This checkbox defaults to False, as it generates a simple legend when set to True, see matplotlib.pyplot.legend(), which clobbers any carefully handcrafted legend.
    anykraus committed Apr 22, 2014
    Copy the full SHA
    63894f9 View commit details
    Browse the repository at this point in the history

  2. re-generate legend: re-use: ncol and draggable 

    Copy some properties from the old legend to the new (re-)generated legend.
If the old legend was draggable, the new one is now also.
The number of columns in the legend is passed on from to old legend to the new legend.
    anykraus committed Apr 22, 2014
    Copy the full SHA
    80beedf View commit details
    Browse the repository at this point in the history

  3. re-generate legend: fixes 

    Fixed crash if there was no previous legend.
Fixed ncol inheritance.
    anykraus committed Apr 22, 2014
    Copy the full SHA
    07930c0 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2014

  1. pep8 compliance 

    Ran pep8.py 1.5.6 (https://github.com/jcrocholl/pep8) over the code.
Fixed all complaints.
    anykraus committed Apr 23, 2014
    Copy the full SHA
    af30544 View commit details
    Browse the repository at this point in the history

  2. figureoptions.py is now pep8 compliant 

    */matplotlib/backends/qt4_editor/figureoptions.py
now passes pep8 checks.
    anykraus committed Apr 23, 2014
    Copy the full SHA
    9ede5be View commit details
    Browse the repository at this point in the history