Fix and new test for #3327 #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a side note, if you just |
|
The test looks much better. Looking at this again, I take back my earlier comments about back compatibility. I was confused. 👍 from me. |
|
@mdboom I think this is fine to go in for 1.4.0 (we have to do rc3 due to the memory patch anyway), but will defer to you on this. |
|
Ah ok, thanks for the tip. I didn't know and I didn't want to take the risk to confuse github. |
|
No worries, git and github have non trivial learning curves (but are wonderful once you are past the initial slope). |
|
Sorry, I lost track of this and it did not make it into 1.4.0. |
tacaswell
added a commit
that referenced
this pull request
Aug 26, 2014
BUG : use copy of font-properties for each axes title closes #3327
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #3328 to fix #3327.
The fix is the same, but I'm using another branch to avoid having useless images in the repo history (see this comment in the old discussion).