Data limits in scatter function #3481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ints given as input and not using the scatter point's collections auto limits.
| @@ -3657,7 +3657,8 @@ def scatter(self, x, y, s=20, c='b', marker='o', cmap=None, norm=None, | |||
| if self._ymargin < 0.05 and x.size > 0: | |||
| self.set_ymargin(0.05) | |||
|
|
|||
| self.add_collection(collection) | |||
| self.add_collection(collection, autolim=False) | |||
| self.update_datalim(offsets) | |||
There was a problem hiding this comment.
This doesn't make sense to me. What if transOffset is not transData? It seems like add_collection should be handling all this correctly, and if it isn't then that is what needs to be fixed, not the code in scatter.
My impression is that the problem is coming from the basic design of mpl, in which some variables are set, calculations are done, and then later changes in those variables are not taken into account. The only way around it is a major redesign in which a full dependency relationship is established, and the evaluation occurs only at the last moment.
|
Tests are currently failing |
|
This seems to have been a dead-end. Thanks for the contribuiton - feel free to re-open if I'm misinterpreting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the data limits in a scatter plot with just the (x,y) input points. Currently, the
scatterfunction creates a collection of markers which then are allowed to update the data limits. This has unintended consequences as seen in issue #3059.