Silince UnicodeWarnings in tests #3674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3828,9 +3828,9 @@ def __init__(self, dataset, bw_method=None): | |||
|
|
|||
| if bw_method is None: | |||
| pass | |||
| elif bw_method == 'scott': | |||
There was a problem hiding this comment.
I think a better fix would be to move this test below the tests for callable or guard them with not isinstance(bw_method, six.stirng_types).
Ensure that bw_method is a string before comparing to strings
Ensure that rotation is string before comparing to string and raise ValueError if rotation could not be converted to float
jenshnielsen
force-pushed
the
text_warning
branch
from
c90339a
to
43e7831
Compare
jenshnielsen
force-pushed
the
text_warning
branch
from
43e7831
to
5c12679
Compare
|
Good points. I initially did the smallest changes needed but we might as well do this probably. I have implemented your suggestions with a few variations. In addition i added a few unittests to get_rotation |
| angle = float(rotation) | ||
| return angle % 360 | ||
|
|
||
| except (ValueError, TypeError): |
There was a problem hiding this comment.
float(None) raises a TypeError
tacaswell
added a commit
that referenced
this pull request
Oct 19, 2014
ENH : Silince UnicodeWarnings in tests
|
|
||
| return angle |
There was a problem hiding this comment.
Now that I have merged this I noticed that the mod 360 got dropped, was that intentional?
There was a problem hiding this comment.
Nope, Missed that, Will fix in a new pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes warning like the following in the test output:
The changes are somewhat stupid and redundant and the only purpose is to fix the warnings.