Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to doc/conf.py to allow for building docs without qt installed #3799

Merged

Conversation

cimarronm
Copy link
Contributor

Had to modify mocksip in conf.py from a simple MagicMock object to one with a getapi function to avoid the following type error:

Exception occurred:
  File "/Users/cimarron/github/matplotlib/lib/matplotlib/backends/qt_compat.py", line 94, in <module>
    if sip.getapi("QString") > 1:
TypeError: unorderable types: MagicMock() > int()

@cimarronm
Copy link
Contributor Author

@jenshnielsen, can you review to make sure it looks fine or needs further modifications

@jenshnielsen
Copy link
Member

It looks sensible to me, I don't know why I didn't see this and Travis is happy without it.

The build is currently failing on Travis. I think this is because you need to instantiate mocksip before using it. I made a pr against your branch to fix this.

@jenshnielsen
Copy link
Member

Travis is happy. And the change looks good to me. Merging.

jenshnielsen added a commit that referenced this pull request Nov 15, 2014
Update to doc/conf.py to allow for building docs without qt installed
@jenshnielsen jenshnielsen merged commit f8e829b into matplotlib:master Nov 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants