V1.4.x - Remove test dependencies from install_requires #4188

HolgerPeters · 2015-03-04T12:11:12Z

See issue #4110 and #3659 reviving

Hope the rebase worked out

tacaswell · 2015-03-04T14:47:12Z

Can you also address all of the documentation related concerns from the original PR?

HolgerPeters · 2015-03-04T19:06:50Z

I will update the docs shortly

HolgerPeters · 2015-03-04T19:37:04Z

Should I restore the tests.py file for invocation of single tests and for the invocation of tests from an outside directory? People would not have to change their workflows and that script does not necessarily hurt. Of course we could parameterize the tests command further, but a setuptools command is limited, as all parameters have to be spelled out.

Note that I am still very much in favor of python setup.py test for the general invocation of tests.

My main interest in this pull requests is to remove the test dependencies from the install dependencies, so whatever you prefer would be fine in terms of tests.py.

tacaswell · 2015-03-04T21:52:24Z

The ability to run just a sub-set of the tests is a critical ability (given how long it takes to run the full test suite) for developers.

It would be great to keep tests.py around as a compatibility layer (even if it just calls the setup.py version under the hood).

Does python setup.py test play nice with python setup.py develop?

Does setup.py get shipped when mpl is built by conda/linux packagers? Does this affect end-users of those packages ability to run the tests?

HolgerPeters · 2015-03-05T07:19:14Z

python setup.py test installs test dependencies as eggs into the current directory runs setup.py egg_info, setup.py build_ext and then runs the tests. It does play nice with python setup.py develop in my experience (it is kind of made for the development solution). Key feature is, that it uses the tests_require option of setuptools for spelling out the dependencies of the test.
end users can still run matplotlib.test(), they might have to install nose as a dependency manually (with the corresponding conda install command) if it is not part of the base installation. I do not know whether setup.py is shipped with conda packages, Python wheels do not contain the setup.py (see https://www.python.org/dev/peps/pep-0427/#file-contents PEP 427). Keep in mind that this pull request was triggered by my issue Matplotlib Installing Test Dependencies #3649 -- I do not like that matplotlib lists a testing library in its install requirements when its a testing requirement.
I will restore tests.py

tacaswell · 2015-03-05T15:51:14Z

.travis.yml

@@ -6,8 +6,7 @@ env:
    - secure: E7OCdqhZ+PlwJcn+Hd6ns9TDJgEUXiUNEI0wu7xjxB2vBRRIKtZMbuaZjd+iKDqCKuVOJKu0ClBUYxmgmpLicTwi34CfTUYt6D4uhrU+8hBBOn1iiK51cl/aBvlUUrqaRLVhukNEBGZcyqAjXSA/Qsnp2iELEmAfOUa92ZYo1sk=
    - secure: "dfjNqGKzQG5bu3FnDNwLG8H/C4QoieFo4PfFmZPdM2RY7WIzukwKFNT6kiDfOrpwt+2bR7FhzjOGlDECGtlGOtYPN8XuXGjhcP4a4IfakdbDfF+D3NPIpf5VlE6776k0VpvcZBTMYJKNFIMc7QPkOwjvNJ2aXyfe3hBuGlKJzQU="
    - BUILD_DOCS=false
-    - TEST_ARGS=--no-pep8
-    - NUMPY=numpy


Don't we need this for the build matrix to work right?

Or, is line 26 working because something else in there depends on numpy?

HolgerPeters · 2015-03-11T10:41:12Z

I just rebased on latest master

WeatherGod · 2015-03-11T14:28:55Z

doc/devel/testing.rst

-causing known-failing tests to fail for real.
+Running tests by any means other than `matplotlib.test()` does not
+load the nose "knownfailureif" (Known failing tests) plugin, causing
+known-failing tests to fail for real.


Is this statement still true?

WeatherGod · 2015-03-11T14:40:53Z

Travis completely failed to build the docs. There isn't even an index.html, it seems.

jenshnielsen · 2015-03-11T14:44:31Z

@WeatherGod We are failing hard on Sphinx warnings when building the docs on Travis and it seems like this warning happens early on

HolgerPeters · 2015-03-17T09:09:49Z

Will take a look at failing docs in my branch, however not before next week.

jenshnielsen · 2015-03-17T09:16:29Z

@HolgerPeters The build failure of the docs is due to the release of Sphinx 1.3 which broke some things and have nothing to do with your branch AFAIK. In current master we pin Sphinx at 1.2.3 (while we work on resolving the issue). Rebasing on current master is one way of fixing it.

tacaswell · 2015-05-24T19:39:19Z

@HolgerPeters This needs a re-base again.

HolgerPeters · 2015-05-27T08:33:16Z

@tacaswell Will you merge this pull request once it has been rebased? I have rebased it before and it wasn't merged so I wouldn't want to rebase it now, without knowing that you have the intention to merge it.

tacaswell · 2015-05-27T12:33:27Z

Sorry this is getting dragged out, everyone who works on MPL is doing it more-or-less on a volunteer basis so things happen at what ever pace they happen at. The delay in review is an issue of resources not malice. If we had no intention of merging this we would have just closed it initially.

I suspect the conflict is in .travis.yml which we have been thrashing on

HolgerPeters · 2015-05-28T07:56:55Z

Hmm, it seems that tests requirements are not installed in https://travis-ci.org/matplotlib/matplotlib/jobs/64324176 will try to fix this.

QuLogic · 2015-05-28T08:07:56Z

doc/devel/testing.rst



 An alternative implementation that does not look at command line
-arguments works from within Python::
+arguments works from within Python is to run the tests from the
+matplotlibs library function :func:`matplotlib.test`::


s/matplotlibs/matplotlib/

- add setup.py test command for test execution - modify setupext's logic for dependency determination for a test requirements list - add nose to test requirements - update documentation accordingly This reverts commit 3d622fe. install mock for dock building

HolgerPeters · 2015-05-29T15:21:31Z

I just squashed the pull request as travis jobs have all built. Hope that you will merge it so #3649 is fixed.

HolgerPeters · 2015-06-05T21:33:22Z

Please merge or find another way to fix #3649 . I will not rebase this pull request a third time.

tacaswell · 2015-06-05T22:49:43Z

setup.py

+    description = "Invoke unit tests using nose after an in-place build."
+    user_options = [
+        ("pep8-only", None, "pep8 checks"),
+        ("omit-pep8", None, "Do not perform pep8 checks"),


Are these standard names? If not can you revert these to the flags we were using before?

I wrote this so long ago I can hardly remember if I changed those names (I presume I did) . Probably I had the impression that the flags from the script runner were ambiguous.

tacaswell · 2015-06-16T02:05:30Z

Ping @HolgerPeters

tacaswell · 2015-07-14T15:37:56Z

@HolgerPeters This was merged in #4668, closing.

tacaswell added the status: needs review label Mar 4, 2015

tacaswell added this to the next point release milestone Mar 4, 2015

tacaswell reviewed Mar 5, 2015
View reviewed changes

HolgerPeters changed the title ~~V1.4.x~~ V1.4.x - Remove test dependencies from install_requires Mar 9, 2015

HolgerPeters force-pushed the v1.4.x branch from 4d72d69 to 2d8944a Compare March 11, 2015 10:40

WeatherGod reviewed Mar 11, 2015
View reviewed changes

HolgerPeters force-pushed the v1.4.x branch 2 times, most recently from 594c5eb to e22f1b0 Compare March 24, 2015 15:31

HolgerPeters force-pushed the v1.4.x branch from e22f1b0 to b50bf7b Compare May 27, 2015 21:16

QuLogic reviewed May 28, 2015
View reviewed changes

HolgerPeters force-pushed the v1.4.x branch from 51d71ad to 9c000db Compare May 29, 2015 15:19

tacaswell reviewed Jun 5, 2015
View reviewed changes

tacaswell mentioned this pull request Jul 2, 2015

Anaconda's matplotlib 1.4.3 build 2 adds new dependency on mock ContinuumIO/anaconda-issues#349

Open

tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jul 2, 2015

This was referenced Jul 11, 2015

Remove test dependencies from install_requires #4668

Merged

TST: Enable coveralls/codecov code coverage #4678

Merged

Travis: Upgrade pip and setuptools #4687

Merged

tacaswell closed this Jul 14, 2015

tacaswell removed the status: needs review label Jul 14, 2015

QuLogic mentioned this pull request Aug 13, 2015

Matplotlib Installing Test Dependencies #3649

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V1.4.x - Remove test dependencies from install_requires #4188

V1.4.x - Remove test dependencies from install_requires #4188

HolgerPeters commented Mar 4, 2015

tacaswell commented Mar 4, 2015

HolgerPeters commented Mar 4, 2015

HolgerPeters commented Mar 4, 2015

tacaswell commented Mar 4, 2015

HolgerPeters commented Mar 5, 2015

tacaswell Mar 5, 2015

tacaswell Mar 5, 2015

HolgerPeters commented Mar 11, 2015

WeatherGod Mar 11, 2015

WeatherGod commented Mar 11, 2015

jenshnielsen commented Mar 11, 2015

HolgerPeters commented Mar 17, 2015

jenshnielsen commented Mar 17, 2015

tacaswell commented May 24, 2015

HolgerPeters commented May 27, 2015

tacaswell commented May 27, 2015

HolgerPeters commented May 28, 2015

QuLogic May 28, 2015

HolgerPeters commented May 29, 2015

HolgerPeters commented Jun 5, 2015

tacaswell Jun 5, 2015

HolgerPeters Jun 16, 2015

tacaswell commented Jun 16, 2015

tacaswell commented Jul 14, 2015

V1.4.x - Remove test dependencies from install_requires #4188

V1.4.x - Remove test dependencies from install_requires #4188

Conversation

HolgerPeters commented Mar 4, 2015

tacaswell commented Mar 4, 2015

HolgerPeters commented Mar 4, 2015

HolgerPeters commented Mar 4, 2015

tacaswell commented Mar 4, 2015

HolgerPeters commented Mar 5, 2015

tacaswell Mar 5, 2015

Choose a reason for hiding this comment

tacaswell Mar 5, 2015

Choose a reason for hiding this comment

HolgerPeters commented Mar 11, 2015

WeatherGod Mar 11, 2015

Choose a reason for hiding this comment

WeatherGod commented Mar 11, 2015

jenshnielsen commented Mar 11, 2015

HolgerPeters commented Mar 17, 2015

jenshnielsen commented Mar 17, 2015

tacaswell commented May 24, 2015

HolgerPeters commented May 27, 2015

tacaswell commented May 27, 2015

HolgerPeters commented May 28, 2015

QuLogic May 28, 2015

Choose a reason for hiding this comment

HolgerPeters commented May 29, 2015

HolgerPeters commented Jun 5, 2015

tacaswell Jun 5, 2015

Choose a reason for hiding this comment

HolgerPeters Jun 16, 2015

Choose a reason for hiding this comment

tacaswell commented Jun 16, 2015

tacaswell commented Jul 14, 2015