API/FIX : don't accept None for x or y in plot #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -263,6 +263,14 @@ def _plot_args(self, tup, kwargs): | |||
| raise ValueError('third arg must be a format string') | |||
| else: | |||
| linestyle, marker, color = None, None, None | |||
|
|
|||
| # check that n values of None are passed in | |||
There was a problem hiding this comment.
"n" -> "no". Comment could be clarified a bit:
Don't allow any None values; a None would be converted
to a one-element array of None, which would fail downstream.
The comment is probably overkill; there was never any
reason to think None should be allowed, it just was
not explicitly blocked because we didn't attempt exhaustive
argument validation.
There was a problem hiding this comment.
I want to leave the comment as I started to solve this by forcing the input to be float-like, but that would break datetime support (and I suspect bunches of the unit-aware code).
This addresses matplotlib#4339 by preventing it.
tacaswell
force-pushed
the
api_dontplot_None
branch
from
fd534e1
to
7674cb2
Compare
|
@efiring Wording fixed + doc + tests + squashed and rebased. |
efiring
added a commit
that referenced
this pull request
Apr 19, 2015
API/FIX : don't accept None for x or y in plot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #4339 by preventing it.
Other option are to convert
None->np.nan.