FIX : turn path snapping off on 'o' marker path #4422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the _snap_threshold for 'o' markers to `np.inf` which effectively turns it off. This makes 'o' markers look more circular at all sizes at all dpi. This change subtly changed several tests. Closes matplotlib#4421
this PR
curent-ish master
This looks slightly different from the image in #4421 at ms=7, but that is because these are saved at 100 dpi, not 72 |
|
Thanks -- sorry I hadn't squashed it completely earlier. |
|
Looks good to me. Should this be backported? |
|
I am mildly 👎 on backporting. It is a subtle API break (even if it is for the better). |
|
Ok, I don't feel strongly either way |
efiring
added a commit
that referenced
this pull request
May 13, 2015
FIX : turn path snapping off on 'o' marker path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the _snap_threshold for 'o' markers to
np.infwhicheffectively turns it off.
This makes 'o' markers look more circular at all sizes at all dpi.
This change subtly changed several tests.
Closes #4421