Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mep12 on color by yvalue.py #4729

Closed

Conversation

domspad
Copy link

@domspad domspad commented Jul 17, 2015

pylab to plt and np

@tacaswell tacaswell added this to the proposed next point release milestone Jul 17, 2015
@jenshnielsen jenshnielsen added the MEP: MEP12 gallery and examples improvements label Jul 17, 2015
@efiring
Copy link
Member

efiring commented Jul 18, 2015

pep 8 failure (missing blank line); otherwise, probably OK.

@jenshnielsen
Copy link
Member

@domspad

You can run pep8 locally before committing to save the trouble of the pep8 issues.

You should be able to do pip install pep8

and then run

python tests.py --pep8

from the main matplotlib dir to check before committing to git

@jenshnielsen
Copy link
Member

@domspad Do you have time to work on this or Is it ok for me to finish it.
@ericmjl Can you skip the 5 examples in this PR so that we don't duplicate work?

@ericmjl
Copy link
Contributor

ericmjl commented Aug 6, 2015

No problem, I will skip them.

@ericmjl
Copy link
Contributor

ericmjl commented Aug 6, 2015

From what I remember, @domspad and I decided that he would work from the front, and I would work from the back. So I'm going from letter Z backwards in the examples set. Still a whiles away from C.

@jenshnielsen
Copy link
Member

@ericmjl Sounds good

@domspad
Copy link
Author

domspad commented Aug 8, 2015

Hey @jenshnielsen sorry, been a bit swamped lately. Feel free to finish it. Otherwise I'll probably not get to it until next week.

@jenshnielsen
Copy link
Member

@domspad No problem. Just want to make sure that your work isn't lost

@tacaswell
Copy link
Member

@jenshnielsen jenshnielsen mentioned this pull request Aug 16, 2015
@jenshnielsen
Copy link
Member

replaced by #4934

@QuLogic QuLogic modified the milestones: v1.5.0, proposed next point release (2.1) Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MEP: MEP12 gallery and examples improvements status: duplicate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants