New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements a new version of symlog that is smooth around linthresh #481
Conversation
…ntributed by ssyr. Also includes a cleaner implementation of the symlog ticker. Closes matplotlib#396.
@efiring: Can you elaborate on where the mask is being thrown away? Plotting a masked array does appear to work. |
On 09/19/2011 04:02 AM, Michael Droettboom wrote:
I have not tested in actual use, so maybe this is being compensated or |
Ok. It doesn't seem to make any practical difference, but I've removed the "asarray" calls in the transformation functions. |
Those asarray() calls wouldn't change anything. I think it is the calls to asarray() for the returns that could be the issue. I don't see why we even need a call to asarray() there (except possibly for the second return, but that should still be asanyarray() |
Ben, I don't see how you can say those initial asarray calls don't change anything; they are explicitly throwing away any mask at the start. |
Sorry, I wasn't clear... they don't do anything useful for the code and are completely unnecessary. |
I've removed all of the redundant "asarray"s. I believe this pull is ready to merge now. |
Implements a new version of symlog that is smooth around linthresh
Implements a new version of symlog that is smooth around linthresh contributed by ssyr. Also includes a cleaner implementation of the symlog ticker. Closes #396.