Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MEP22 warnings #5017

Merged
merged 2 commits into from Sep 3, 2015
Merged

MEP22 warnings #5017

merged 2 commits into from Sep 3, 2015

Conversation

OceanWolf
Copy link
Member

Warnings for MEP22

tacaswell added a commit that referenced this pull request Sep 3, 2015
@tacaswell
Merge pull request #5017 from OceanWolf/MEP22-warnings
7c1993d 
DOC: MEP22 warnings
@tacaswell tacaswell merged commit 7c1993d into matplotlib:master Sep 3, 2015
@OceanWolf
Copy link
Member Author

Gah, I missed out an import warnings in backend_tools.py, this was why I wanted #4810, so Travis would catch such silly errors. I suppose I have to create a separate PR for that? Also a separate branch?

@WeatherGod
Copy link
Member

Actually, it can technically be the same branch, but it obviously needs to
be a new PR.

On Thu, Sep 3, 2015 at 5:47 PM, OceanWolf notifications@github.com wrote:

Gah, I missed out an import warnings in backend_tools.py, this was why I
wanted #4810 #4810, so
Travis would catch such silly errors. I suppose I have to create a separate
PR for that? Also a separate branch?

—
Reply to this email directly or view it on GitHub
#5017 (comment)
.

@OceanWolf
Copy link
Member Author

Thanks for the advice, done it in #5024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OceanWolf @WeatherGod @tacaswell