Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jquery and jquery-ui #5091

Merged
merged 3 commits into from Sep 24, 2015
Merged

Conversation

jkseppan
Copy link
Member

And include their source code, closes #5083 (also makes it somewhat
moot since the newer versions are MIT licensed only).

And include their source code, closes matplotlib#5083 (also makes it somewhat
moot since the newer versions are MIT licensed only).
@jkseppan
Copy link
Member Author

Some brief testing on my system doesn't show that anything is broken by this change.

@tacaswell tacaswell added this to the next point release (1.5.0) milestone Sep 16, 2015
@tacaswell
Copy link
Member

Can you put the MIT license in the license folder?

https://github.com/matplotlib/matplotlib/tree/master/LICENSE

@jkseppan
Copy link
Member Author

Yes, that latest commit adds it in LICENSE/LICENSE_JQUERY. I included the copyright notices from the jquery files.

@tacaswell
Copy link
Member

This only affects the webagg backend, not nbagg where we use what ever version of jquery that is supplied by jupyyter.

@tacaswell
Copy link
Member

Tested out webagg example, works.

This is technically an API change as we are no longer shipping the same version of jquery and users could be grabbing it by name, I will add the docs in a new PR.

tacaswell added a commit that referenced this pull request Sep 24, 2015
MNT: Upgrade jquery and jquery-ui

Adds license text for debian
@tacaswell tacaswell merged commit e94c609 into matplotlib:master Sep 24, 2015
@tacaswell
Copy link
Member

attn @sandrotosi I believe that debian's concerns have been addressed two ways 1) no longer using a GPL version of jquery 2) including the license

@sandrotosi
Copy link
Contributor

plus having the un-minified version in the repo (and even in the released tarball right? should be implicitly covered by the current MANIFEST.in, but just want to be sure) - that's great guys, thanks a ton!! if you could also consider a release with this and the removal of Lena Söderberg image taht would be fantastic

@tacaswell
Copy link
Member

Lena is already gone from the 1.5rc1 tag, this will be in 1.5rc2

On Thu, Sep 24, 2015, 04:27 Sandro Tosi notifications@github.com wrote:

  • having the un-minified version in the repo (and even in the released
    tarball right? should be implicitly covered by the current MANIFEST.in, but
    just want to be sure) - that's great guys, thanks a ton!! if you could also
    consider a release with this and the removal of Lena Söderberg image taht
    would be fantastic


Reply to this email directly or view it on GitHub
#5091 (comment)
.

@sandrotosi
Copy link
Contributor

@tacaswell do you have any estimate on when 1.5rc2 will be tagged? I'd like to use this weekend to upload that version in Debian (which also will give more exposure to mpl on unconventional archs)

@tacaswell
Copy link
Member

Maybe tonight.

On Fri, Oct 2, 2015, 16:51 Sandro Tosi notifications@github.com wrote:

@tacaswell https://github.com/tacaswell do you have any estimate on
when 1.5rc2 will be tagged? I'd like to use this weekend to upload that
version in Debian (which also will give more exposure to mpl on
unconventional archs)


Reply to this email directly or view it on GitHub
#5091 (comment)
.

@sandrotosi
Copy link
Contributor

awesome, thanks (also for the super fast reply)!

@jkseppan jkseppan deleted the jquery-source branch October 3, 2015 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please include un-minified version of JQuery
3 participants