New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade jquery and jquery-ui #5091
Conversation
And include their source code, closes matplotlib#5083 (also makes it somewhat moot since the newer versions are MIT licensed only).
Some brief testing on my system doesn't show that anything is broken by this change. |
Unsure about license, but this isn't referenced from anywhere
Can you put the MIT license in the license folder? https://github.com/matplotlib/matplotlib/tree/master/LICENSE |
Yes, that latest commit adds it in LICENSE/LICENSE_JQUERY. I included the copyright notices from the jquery files. |
This only affects the webagg backend, not nbagg where we use what ever version of jquery that is supplied by jupyyter. |
Tested out webagg example, works. This is technically an API change as we are no longer shipping the same version of jquery and users could be grabbing it by name, I will add the docs in a new PR. |
MNT: Upgrade jquery and jquery-ui Adds license text for debian
attn @sandrotosi I believe that debian's concerns have been addressed two ways 1) no longer using a GPL version of jquery 2) including the license |
plus having the un-minified version in the repo (and even in the released tarball right? should be implicitly covered by the current MANIFEST.in, but just want to be sure) - that's great guys, thanks a ton!! if you could also consider a release with this and the removal of Lena Söderberg image taht would be fantastic |
Lena is already gone from the 1.5rc1 tag, this will be in 1.5rc2 On Thu, Sep 24, 2015, 04:27 Sandro Tosi notifications@github.com wrote:
|
@tacaswell do you have any estimate on when 1.5rc2 will be tagged? I'd like to use this weekend to upload that version in Debian (which also will give more exposure to mpl on unconventional archs) |
Maybe tonight. On Fri, Oct 2, 2015, 16:51 Sandro Tosi notifications@github.com wrote:
|
awesome, thanks (also for the super fast reply)! |
And include their source code, closes #5083 (also makes it somewhat
moot since the newer versions are MIT licensed only).