Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: drop py2.6 & py3.3 testing #5215

Merged
merged 2 commits into from Oct 28, 2015

Conversation

tacaswell
Copy link
Member

As discussed on the mailing list, going forward we will be dropping
support for python 2.6 and python 3.3.

This allows mpl to use ordered dicts and is required for in-progress
traitlet/serialization work.

  • moved minimum support numpy test to 2.7
  • moved pandas optional test dep to 3.5

http://matplotlib.1069221.n5.nabble.com/Matplotlib-devel-supported-python-versions-tt46154.html

@tacaswell tacaswell added this to the proposed next point release (2.1) milestone Oct 8, 2015
@tacaswell
Copy link
Member Author

This is a pre-req for getting #4762 merged.

@tacaswell
Copy link
Member Author

@matthew-brett @blink1073 Who do I ask nicely to get a pandas 3.5 wheel built?

@blink1073
Copy link
Member

On it.

@blink1073
Copy link
Member

Now available.

@tacaswell
Copy link
Member Author

If this passes I will squash these to 1 or 2 commits.

@tacaswell
Copy link
Member Author

Thanks!

On Thu, Oct 8, 2015 at 4:08 PM Steven Silvester notifications@github.com
wrote:

Now available.


Reply to this email directly or view it on GitHub
#5215 (comment)
.

As discussed on the mailing list, going forward we will be dropping
support for python 2.6 and python 3.3.

This allows mpl to use ordered dicts and is required for in-progress
traitlet/serialization work.

 - moved minimum support numpy test to 2.7
 - moved pandas optional test dep to 3.5

http://matplotlib.1069221.n5.nabble.com/Matplotlib-devel-supported-python-versions-tt46154.html
- python: 2.7
env: MOCK=mock PANDAS=pandas
- python: 3.3
env: MOCK=mock NUMPY=numpy==1.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any plans to drop support for numpy 1.6? I think version 1.7 came out in early 2013, and supporting 1.6 seems to accumulate some preprocessor cruft.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should ask the numpy folks how many versions back they are supporting bug fixes for and don't go further back than that.

I am 👍 on dropping old versions of numpy, but that should be a separate discussion.

@jkseppan
Copy link
Member

Also a prerequisite for #5295. I'm 👍 on merging this.

This is marked for the 2.1 milestone, but if I understood the mailing list post correctly, we'll be dropping official support for Python 2.6 in 2.0, so I think it makes sense to stop testing with 2.6 already in 2.0.

@mdboom
Copy link
Member

mdboom commented Oct 26, 2015

I'd want confirmation from @tacaswell that our understanding is correct that we'll drop Python 2.6 for matplotlib 2.0. It would be nice, because now we have a dependency that "new styles" --> depends on --> "new fonts" --> depends on --> "fixing font file caching" --> depends on --> "lru_cache which hasn't been backported to 2.6". So it will be hard to disentangle removing Python 2.6 support.

@tacaswell tacaswell modified the milestones: next major release (2.0), proposed next point release (2.1) Oct 26, 2015
@tacaswell
Copy link
Member Author

I think the net result of the mailing list discussion was that we are going to drop 'official' support for 2.6 in 1.5 as we do not want commit to releasing a 2.6 compatible bug fix 1.5.1. No one volunteered to manage that and no one said that 2.6 is critical to them.

We should probably back-port this to the 1.5.x branch as soon as we make it as well.

@mdboom
Copy link
Member

mdboom commented Oct 26, 2015

Sure. Let's release 1.5.0 final and then immediately merge this and backport it to 1.5.x.

@tacaswell
Copy link
Member Author

This is blocking other PRs, might as well merge this now. I don't think we will have issues remembering to backport it tomorrow 👿

jenshnielsen added a commit that referenced this pull request Oct 28, 2015
@jenshnielsen jenshnielsen merged commit 84afab1 into matplotlib:master Oct 28, 2015
@tacaswell tacaswell deleted the tst_drop_old_pythons branch October 28, 2015 14:45
@mdboom
Copy link
Member

mdboom commented Oct 28, 2015

👏

@mdboom
Copy link
Member

mdboom commented Oct 30, 2015

Backported to v2.0.x as 1b243ed

jenshnielsen added a commit that referenced this pull request Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants