BUG: arrowhead drawing code #5392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
had the instructions for drawing the left part, and the right part, concatenated the two, without chopping off enough of the left part instructions.
|
partly fixes issue #5344, the arrowhead drawing part. arrowhead direction still wrong. |
|
Thanks. Have you looked into how hard it will be to fix the arrowhead direction? |
|
👍 on merging this as-is |
|
👍 How easy is it to add a test for this? |
|
Sorry this sat for so long without attention. Retstarting tests against current master. |
|
Don't see why this can't be merged... |
|
Backported to v2.x via 64cee30. |
QuLogic
modified the milestones:
2.0.1 (next bug fix release),
2.0 (style change major release)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing a left part drawing instruction fixes
an arrowhead drawing problem.