Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fixes matplotlib/matplotlib#1235 #6110
Conversation
mdboom
added the
needs_review
label
Mar 5, 2016
jenshnielsen
added this to the
2.0 (style change major release)
milestone
Mar 5, 2016
|
AppVeyor builds are failing; but I cannot make sense of the logs. Can someone enlighten me? |
|
See #6115 That is probably unrelated to your work |
tacaswell
and 1 other
commented on an outdated diff
Mar 6, 2016
|
Other that 1 very minor style point |
QuLogic
and 2 others
commented on an outdated diff
Mar 6, 2016
| @@ -261,6 +262,31 @@ def test_nanscatter(): | ||
| ax.grid(True) | ||
| +@image_comparison(baseline_images=['not_covering_scatter'], extensions=['png']) | ||
| +def test_not_covering_scatter(): | ||
| + colors = ['b','g','r'] | ||
| + | ||
| + for n in range(3): | ||
| + plt.scatter([n,], [n,], color=colors[n]) | ||
| + | ||
| + plt.legend(['foo', 'foo', 'foo'], loc='best') | ||
| + plt.gca().set_xlim(-0.5, 2.2) | ||
| + plt.gca().set_ylim(-0.5, 2.2) | ||
| + | ||
| + | ||
| +@image_comparison(baseline_images=['not_covering_scatter_transform'], extensions=['png']) |
dashed
Contributor
|
|
@tacaswell I rebased against master that has #6116, and seems to work. Unsure what happened here: https://ci.appveyor.com/project/mdboom/matplotlib/build/1.0.985/job/4u3na3cignvxhg2n |
|
That is a known transient failure. |
tacaswell
added a commit
that referenced
this pull request
Mar 7, 2016
|
|
tacaswell |
01c73b4
|
tacaswell
merged commit 01c73b4
into matplotlib:master
Mar 7, 2016
tacaswell
removed the
needs_review
label
Mar 7, 2016
tacaswell
added a commit
that referenced
this pull request
Mar 7, 2016
|
|
tacaswell |
869cc9d
|
|
backported to v2.x as 869cc9d |
|
Thanks @tacaswell |
nansonzheng commentedMar 5, 2016
Credit to @dashed, fixes #1235, supercedes #2857
The problem is that _find_best_position does not receive positions of (transformed) points from _auto_legend_data. We attempted to fix it by adding the offsets of points, after preparing the points and transforming them, and calling legendBox.count_contains on offsets.