Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
TST: skip broken test #6263
Conversation
tacaswell
added the
needs_review
label
Apr 2, 2016
|
Bah, this order of the decorators does not work because the failure happens in the outer decorator so barfs on not failing. Ordering the decorators the other order fails on definition. |
|
I think you could just raise |
|
The only downside of that is that the knownfailure could hang around forever, the decorator checks that it actually fails in the cases where it is known to fail |
tacaswell
added this to the
1.5.2 (Critical bug fix release)
milestone
Apr 3, 2016
|
This has un-broken all of our CI. I have it tagged an 1.5.2 to backport it back to 1.5.x (as eventually we will end up with np1.11 in our test for all running branches. |
|
|
jenshnielsen
merged commit b49bcf4
into matplotlib:master
Apr 3, 2016
mdboom
removed the
needs_review
label
Apr 3, 2016
tacaswell
deleted the
tacaswell:tst_skip_float_rounding_issue_test branch
Apr 3, 2016
jenshnielsen
added a commit
that referenced
this pull request
Apr 3, 2016
|
|
jenshnielsen + jenshnielsen |
44e7356
|
|
Backported to 1.5.x as 44e7356 |
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
May 22, 2016
|
|
jenshnielsen + tacaswell |
76465e3
|
jenshnielsen
added a commit
to jenshnielsen/matplotlib
that referenced
this pull request
Aug 13, 2016
|
|
jenshnielsen |
d38ec34
|
tacaswell commentedApr 2, 2016
This test only over passed due to an error arising from a bug
in numpy's divmod being fixed (numpy/numpy#6127).
See #5950
attn @jenshnielsen