MNT: trap inappropriate use of color kwarg in scatter; closes #6266 #6267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3824,19 +3824,23 @@ def scatter(self, x, y, s=None, c=None, marker='o', cmap=None, norm=None, | |||
| # Process **kwargs to handle aliases, conflicts with explicit kwargs: | |||
|
|
|||
| facecolors = None | |||
| ec = kwargs.pop('edgecolor', None) | |||
| ec = kwargs.pop('edgecolors', None) | |||
There was a problem hiding this comment.
edgecolors is already explicitly named as a keyword argument up above. It would never be in kwargs.
|
besides the one nitpick, this looks fine to me. |
|
I agree with @WeatherGod |
…lib#6266 This slightly modifies and extends the special-casing of color-related kwargs that would otherwise be passed in to a Collection instance. Attempts to use 'color' in place of the 'c' kwarg for color-mapping in scatter are now trapped with a ValueError in most cases. There are still cases that are impossible to trap: a sequence of 3 or 4 floats between 0 and 1 could be either a single color spec or a sequence of values to be color-mapped.
WeatherGod
added a commit
that referenced
this pull request
Apr 8, 2016
MNT: trap inappropriate use of color kwarg in scatter; closes #6266
|
backported to v1.5.x as 1f1b8b8 |
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
May 22, 2016
MNT: trap inappropriate use of color kwarg in scatter; closes matplotlib#6266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly modifies and extends the special-casing of color-related
kwargs that would otherwise be passed in to a Collection instance.
Attempts to use 'color' in place of the 'c' kwarg for color-mapping
in scatter are now trapped with a ValueError in most cases. There
are still cases that are impossible to trap: a sequence of 3 or 4
floats between 0 and 1 could be either a single color spec or a
sequence of values to be color-mapped.