Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
MNT: trap inappropriate use of color kwarg in scatter; closes #6266 #6267
Conversation
efiring
added the
needs_review
label
Apr 3, 2016
WeatherGod
commented on an outdated diff
Apr 5, 2016
lib/matplotlib/axes/_axes.py
| @@ -3824,19 +3824,23 @@ def scatter(self, x, y, s=None, c=None, marker='o', cmap=None, norm=None, | ||
| # Process **kwargs to handle aliases, conflicts with explicit kwargs: | ||
| facecolors = None | ||
| - ec = kwargs.pop('edgecolor', None) | ||
| + ec = kwargs.pop('edgecolors', None) |
WeatherGod
Member
|
|
besides the one nitpick, this looks fine to me. |
tacaswell
added this to the
1.5.2 (Critical bug fix release)
milestone
Apr 7, 2016
|
I agree with @WeatherGod |
WeatherGod
merged commit 0b6aa7b
into matplotlib:master
Apr 8, 2016
mdboom
removed the
needs_review
label
Apr 8, 2016
WeatherGod
added a commit
that referenced
this pull request
Apr 8, 2016
|
|
WeatherGod |
1f1b8b8
|
|
backported to v1.5.x as 1f1b8b8 |
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
May 22, 2016
|
|
WeatherGod + tacaswell |
4390bdf
|
efiring
deleted the
efiring:scatter-color branch
Jun 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
efiring commentedApr 3, 2016
This slightly modifies and extends the special-casing of color-related
kwargs that would otherwise be passed in to a Collection instance.
Attempts to use 'color' in place of the 'c' kwarg for color-mapping
in scatter are now trapped with a ValueError in most cases. There
are still cases that are impossible to trap: a sequence of 3 or 4
floats between 0 and 1 could be either a single color spec or a
sequence of values to be color-mapped.