Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6323: Fix vertical alignment of TeX text #6333

Closed
wants to merge 1 commit into from

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Apr 25, 2016

For some reason, the minus sign is coming in as character code "0", and therefore it uses the wrong height and depth for that character, which I feel must be wrong.

Cc: @jkseppan as our resident DVI expert. Any ideas why that may be the case?

  • Needs a test.

@mdboom mdboom added this to the 2.0 (style change major release) milestone Apr 25, 2016
@jkseppan
Copy link
Member

Code 0 seems to be correct, the minus sign comes from cmsy10 whose encoding table is on page 31 of http://texdoc.net/texmf-dist/doc/latex/base/encguide.pdf

No idea yet why that should have bad dimensions.

@jkseppan
Copy link
Member

I think the minus-sign character has nonzero depth in the font, and tftopl (the official implementation of parsing tfm files) agrees. Is this actually a case of failing to detect the baseline correctly? There's a text.latex.preview parameter that could be related, but I'm running out of time to debug now.

@mdboom
Copy link
Member Author

mdboom commented Apr 25, 2016

Thanks -- it could be all of those things, but I haven't really been able to investigate yet either. I tried text.latex.preview mode, and it has similar results.

@NelleV
Copy link
Member

NelleV commented Nov 11, 2016

I don't think this release critical. Bumping this to 2.0.1

@NelleV NelleV modified the milestones: 2.0.1 (next bug fix release), 2.0 (style change major release) Nov 11, 2016
@tacaswell
Copy link
Member

Side note, the table is now an pg 33 of http://texdoc.net/texmf-dist/doc/latex/base/encguide.pdf

@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0.2 (next bug fix release) May 3, 2017
@tacaswell tacaswell modified the milestones: 2.1.1 (next bug fix release), 2.2 (next feature release) Oct 9, 2017
@tacaswell
Copy link
Member

Closing in favor of #16366 which applies the same fix in _height_depth_of.

@tacaswell tacaswell closed this Jan 29, 2020
@story645 story645 removed this from the future releases milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants