tuples don't have a pop() method. The same change has been made upstream... #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1. Can you rebase this on v1.1.x maintenance -- the bug appears to exist there, too. |
|
Sorry but I am not a git user, and I can't work out how I should do that. For good or for bad I have erased the patch-1 branch. Currently I have 2 commits on my fork. One on master and one on v1.1.x (I cherry picked the commit from master to v1.1.x so they are the same). It seems that I can't add more commits on this pull request. And when I try to make a new pull request I can't find how I can add commits from two different branches. Could you provide some guidance? ps. The time I spent on this is disproportionally large for something so trivial. Perhaps it would be easier if you just took the time to make the change and push it... |
|
Closed by 97c58d2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... too: http://code.google.com/p/formlayout/source/browse/formlayout.py