[DOC] Fix example following comments in issue #6865 #7111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Sep 14, 2016
| # user to select the projection, i.e. ``subplot(111, | ||
| # projection='custom_hammer')``. | ||
| name = 'custom_hammer' | ||
| class ThetaFormatter(Formatter): |
There was a problem hiding this comment.
I think you can import this from matplotlib.projections.polar.ThetaFormatter.
There was a problem hiding this comment.
I think part of the exercise here is to write one mostly from scratch.
| @@ -271,8 +268,8 @@ def format_coord(self, lon, lat): | |||
|
|
|||
| In this case, we want them to be displayed in degrees N/S/E/W. | |||
| """ | |||
| lon = np.degrees(lon) | |||
| lat = np.degrees(lat) | |||
| lon = lon * (180.0 / np.pi) | |||
There was a problem hiding this comment.
Cause it is how it is writtern in geo.py
| longitude_cap = np.radians(degrees) | ||
| # Change the xaxis gridlines transform so that it draws from | ||
| # -degrees to degrees, rather than -pi to pi. | ||
| self._longitude_cap = degrees * (np.pi / 180.0) |
There was a problem hiding this comment.
Cause it is how it is writtern in geo.py
| A custom class for the Aitoff-Hammer projection, an equal-area map | ||
| projection. | ||
|
|
||
| http://en.wikipedia.org/wiki/Hammer_projection |
| http://en.wikipedia.org/wiki/Hammer_projection | ||
| """ | ||
|
|
||
| # The projection must specify a name. This will be used be the |
NelleV
approved these changes
Sep 16, 2016
tacaswell
added a commit
that referenced
this pull request
Sep 16, 2016
DOC: Fix example following comments in issue #6865
QuLogic
modified the milestones:
2.0.1 (next bug fix release),
2.0 (style change major release)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the example by extracting the relevant code from geo.py and copying back comments from the old example.