/matplotlib

Fix double running of explicitly chosen tests. #7498

Merged
merged 1 commit into from Nov 23, 2016

Conversation

Reviewers

@NelleV NelleV

Assignees
No one assigned
Labels
Testing
Projects

Done in Reviewing pull requests.

Milestone
  2.1 (next point r...
3 participants
@QuLogic @tacaswell @NelleV
@QuLogic
Member

QuLogic commented Nov 22, 2016

Running python tests.py matplotlib.tests.... would run the chosen tests twice, causing errors when figures were closed from the first run and then missing in the second run. This is because sys.argv + extra_args produces the test list twice.

cc @Kojoley
@QuLogic QuLogic Fix double running of explicitly chosen tests. 
Running `python tests.py matplotlib.tests....` would run the chosen
tests twice, causing errors when figures were closed from the first run
and then missing in the second run. This is because `sys.argv +
extra_args` produces the test list twice.

Some checks were not successful

1 failing and 2 successful checks
continuous-integration/appveyor/pr — AppVeyor build failed
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 62.01%
Details
8beb3df

QuLogic added the Testing label Nov 22, 2016

QuLogic added this to the 2.1 (next point release) milestone Nov 22, 2016

@QuLogic
Member

QuLogic commented Nov 22, 2016

BTW, I'm pretty sure intentionally specifying a test twice (on the command-line) used to work, so there is still a regression there. This PR only fixes the case where a test is listed once and incorrectly gets run twice.
@NelleV

NelleV approved these changes Nov 22, 2016
View changes

NelleV changed the title from [MRG] Fix double running of explicitly chosen tests. to [MRG+1] Fix double running of explicitly chosen tests. Nov 22, 2016

@tacaswell
Owner

tacaswell commented Nov 23, 2016

Merging on the theory that the one appveyor test that failed is transient (the test already has a higher tolerance on windows than the other platforms).

@tacaswell tacaswell merged commit 1512bee into matplotlib:master Nov 23, 2016
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 62.01%
Details

QuLogic deleted the QuLogic:dedup-tests branch Nov 23, 2016

QuLogic changed the title from [MRG+1] Fix double running of explicitly chosen tests. to Fix double running of explicitly chosen tests. Nov 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment