Fix double running of explicitly chosen tests. #7498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `python tests.py matplotlib.tests....` would run the chosen tests twice, causing errors when figures were closed from the first run and then missing in the second run. This is because `sys.argv + extra_args` produces the test list twice.
|
BTW, I'm pretty sure intentionally specifying a test twice (on the command-line) used to work, so there is still a regression there. This PR only fixes the case where a test is listed once and incorrectly gets run twice. |
NelleV
approved these changes
Nov 22, 2016
NelleV
changed the title
|
Merging on the theory that the one appveyor test that failed is transient (the test already has a higher tolerance on windows than the other platforms). |
QuLogic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
python tests.py matplotlib.tests....would run the chosen tests twice, causing errors when figures were closed from the first run and then missing in the second run. This is becausesys.argv + extra_argsproduces the test list twice.cc @Kojoley