Mrg animation merge #7622
Merged
Mrg animation merge #7622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- always try to call `finish` even if an exception is raised.
- return `self` so that
with writer.saving(...) as mv:
mv.grab_frame()
works as expected.
Closes matplotlib#7595, matplotlib#7493, matplotlib#7587. Bbox._minpos is now initialized to [np.inf, np.inf] instead of [1e-7, 1e-7]. Old code with a colorbar in which the formatter is set to a LogFormatter and a SymlogNorm is used now works again (although the results are better in 2.0 if the colorbar is left to handle the formatter automatically). LogLocator now has its own nonsingular() method which provides a reasonable starting point for a log axis when no data have been plotted.
Delay fc-list warning by 5s.
DOC: fixed typo in mlab.py
Doc animation
BUG: fix minpos handling and other log ticker problems
This bakes into the text artist (via the FontProperties) the default fontsize at the time of creation.
…oviewriter_saving_cm MNT: tweak MovieWriter.saving to be more cautious
This appears to already be the case for all of these properties, but remove the rcparams lookup from the get_* methods just to be sure.
`None` used to be a valid value for the style/slant and variant, however in cc61700 the behavior was changed to look up the defaults as set time (not get time) so there is no reason to allow invalid values to be set to the internal state.
…t_creation_time API: convert string fontsize to points immediately
Conflicts:
lib/matplotlib/animation.py
- had to merge documentation changes with an ABC being
pulled out the top of MovieWriter
lib/matplotlib/font_manager.py
- whitespace conflicts
Current coverage is 62.01% (diff: 85.32%)@@ master #7622 diff @@
==========================================
Files 174 174
Lines 56056 56046 -10
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 34754 34759 +5
+ Misses 21302 21287 -15
Partials 0 0
|
|
Thanks @QuLogic |
|
Well, I did ask for it. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messy merge from 2.x into master, running through PR to let CI have a crack at it.
Plan to self-merge if it passes and no one beats me to it.