Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the artifact upload isn't working: https://travis-ci.org/matplotlib/matplotlib/jobs/188282794#L1227
"gem install travis-artifacts" no longer works, now you have to use the artifacts addon and set some variables. The encrypted variables may need to be updated too. See documentation at https://docs.travis-ci.com/user/uploading-artifacts/
This worked when I tested with my own setup: https://travis-ci.org/jkseppan/matplotlib/builds/188857981
@mdboom, @tacaswell: do you have access to the matplotlib AWS organization and can you ensure that the encrypted Travis variables here are correct? The variable names should be
ARTIFACTS_KEY
andARTIFACTS_SECRET
.