Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: use is not instead of not ... is, etc. #7933

Merged
merged 1 commit into from
Feb 6, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 23, 2017

https://github.com/takluyver/astsearch is great for looking for patterns to fix :-)

@afvincent
Copy link
Contributor

Wouldn't the CI failure be due to numpy issue #3322 (about array_equal)? All the failure tracebacks are similar to

File "/home/travis/build/matplotlib/matplotlib/venv/lib/python2.7/site-packages/numpy/core/numeric.py", line 2119, in array_equal
    return bool(equal(a1,a2).all())
AttributeError: 'NotImplementedType' object has no attribute 'all'

@anntzer
Copy link
Contributor Author

anntzer commented Jan 24, 2017

Yes, basically this needed numpy 1.8.0. Fixed now.

@NelleV
Copy link
Member

NelleV commented Jan 24, 2017

I am pretty sure something is still wrong :)

@anntzer
Copy link
Contributor Author

anntzer commented Jan 24, 2017

Bah, I just dropped that patch.

@NelleV NelleV changed the title Cleanup: use is not instead of not ... is, etc. [MRG+1] Cleanup: use is not instead of not ... is, etc. Jan 25, 2017
@NelleV
Copy link
Member

NelleV commented Jan 25, 2017

@tacaswell We really need to set up appveyor so that the team is able to restart jobs.

@NelleV
Copy link
Member

NelleV commented Jan 25, 2017

Closing and reopening for appveyor.

@NelleV NelleV closed this Jan 25, 2017
@NelleV NelleV reopened this Jan 25, 2017
@NelleV NelleV closed this Jan 27, 2017
@NelleV NelleV reopened this Jan 27, 2017
@QuLogic
Copy link
Member

QuLogic commented Feb 6, 2017

Something is weird in what actually got build on CI; I think a rebase is in order.

@anntzer
Copy link
Contributor Author

anntzer commented Feb 6, 2017

Done (it rebased cleanly).

@QuLogic QuLogic changed the title [MRG+1] Cleanup: use is not instead of not ... is, etc. Cleanup: use is not instead of not ... is, etc. Feb 6, 2017
@QuLogic QuLogic merged commit 07752de into matplotlib:master Feb 6, 2017
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Feb 6, 2017
@anntzer anntzer deleted the cleanup-not-is-is-not branch February 6, 2017 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants