-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup: use is not
instead of not ... is
, etc.
#7933
Conversation
Wouldn't the CI failure be due to numpy issue #3322 (about
|
c1206f4
to
f19e6e8
Compare
Yes, basically this needed numpy 1.8.0. Fixed now. |
I am pretty sure something is still wrong :) |
f19e6e8
to
4093f50
Compare
Bah, I just dropped that patch. |
is not
instead of not ... is
, etc.is not
instead of not ... is
, etc.
@tacaswell We really need to set up appveyor so that the team is able to restart jobs. |
Closing and reopening for appveyor. |
Something is weird in what actually got build on CI; I think a rebase is in order. |
4093f50
to
9bf4238
Compare
Done (it rebased cleanly). |
is not
instead of not ... is
, etc.is not
instead of not ... is
, etc.
https://github.com/takluyver/astsearch is great for looking for patterns to fix :-)