Refactor code duplication in matplotlib.markers
#8340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afvincent
approved these changes
Mar 26, 2017
There was a problem hiding this comment.
Thanks @sindunuragarp, the refactoring looks clean to me :).
Could some core dev check that the merge-rather-than-rebase thing (IIUC the commit history) is OK?
Edit: a question with a question mark is better...
|
Wait, why don't we need that svg file? I think that means a test we think is running is not... |
|
That file should not have been added; it's created by the tests multiple times to be sure determinism works. I think it was moved to a temporary directory at some point, though, so I'm not sure how it accidentally got added. |
|
Great. @sindunuragarp In the future please rebase rather than merging master into your feature branch. |
|
Sorry I'll make sure to remember that 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some code repetition in
lib/matplotlib/markers.pyin the functions to draw specific markers which had orientation differences such asvlineandhline. Both these functions are exactly the same apart for an additional rotation inhline.I saw that the piece of code with duplication has not been updated in a long time, so I tried to refactor it by removing code duplications. I have tried running the tests and I believe no errors occured because of this refactor.