Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pandas package to appveyor configuration #8657

Merged
merged 1 commit into from
May 28, 2017

Conversation

fkohlgrueber
Copy link
Contributor

PR Summary

I appended pandas to the list of packages that are installed into the conda environment that's used for testing on Appveyor.

This lets all tests that depend on pandas run (currently 7). Two of the Travis CI jobs already include pandas and I think that there's no reason not to run these tests on Appveyor as well. Please tell me if there are any.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone May 23, 2017
@tacaswell
Copy link
Member

Thanks for contribution!

My only concern is if the pandas tests add significant overhead (as appevyor is already very slow). 👍 if this adds < 30s to the run time.

@QuLogic
Copy link
Member

QuLogic commented May 28, 2017

Comparing with a random build from master, this PR is 3 minutes slower, but comparing with a random build from a different PR, this PR is 12 minutes faster. So I think whatever the difference is, it's well within the variance of AppVeyor build times. I'll take @tacaswell's conditional 👍 as granted, then.

@QuLogic QuLogic merged commit 5f2d4dd into matplotlib:master May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants