Avoid dividing by zero in AutoMinorLocator (fixes #8804) #9465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Oct 18, 2017
lib/matplotlib/ticker.py
Outdated
| @@ -2545,7 +2545,7 @@ def __call__(self): | |||
| if vmin > vmax: | |||
| vmin, vmax = vmax, vmin | |||
|
|
|||
| if len(majorlocs) > 0: | |||
| if len(majorlocs) >= 2: | |||
There was a problem hiding this comment.
can you just do an early return [] around line 2522 instead of having to handle this case throughout the function?
afvincent
force-pushed
the
fix_div_by_zero_autominorlocator_issue_8804
branch
from
f51fa53
to
44677ff
Compare
|
@anntzer An early return is now performed. I also extended a bit the dedicated test. |
anntzer
reviewed
Oct 18, 2017
lib/matplotlib/ticker.py
Outdated
| @@ -2524,7 +2524,7 @@ def __call__(self): | |||
| # TODO: Figure out a way to still be able to display minor | |||
| # ticks without two major ticks visible. For now, just display | |||
| # no ticks at all. | |||
| majorstep = 0 | |||
| return [] | |||
|
|
|||
| if self.ndivs is None: | |||
| if majorstep == 0: | |||
There was a problem hiding this comment.
i think this can go away too now?
There was a problem hiding this comment.
Indeed... I was a bit too quick.
afvincent
force-pushed
the
fix_div_by_zero_autominorlocator_issue_8804
branch
from
44677ff
to
3418d96
Compare
|
Address @anntzer's last comment (about removing now unnecessary code) and rebased. (The new test was kept unmodified and is still passing) |
|
Thanks @afvincent ! |
tacaswell
added a commit
that referenced
this pull request
Oct 21, 2017
Backport PR #9465 on branch v2.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Get rid of 2
DivisionByZerowarnings by performing a proper early return, which prevents the case noticed by @ffteja in #8804 from happening.PR Checklist