FIX: PyQt versions where showing the Qt versions #9469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the correct versions shown. Signed-off-by: Nick Papior <nickpapior@gmail.com>
|
Just double-checking, this should work even with all those alternative pyqt libraries? |
|
I have no idea. |
|
@WeatherGod He only touched PyQt4 and PyQt5. |
Kojoley
approved these changes
Oct 23, 2017
|
I am referring to PySide, which is capable of being loaded instead of
pyqt{4?, 5?).
…On Mon, Oct 23, 2017 at 6:02 PM, Nikita Kniazev ***@***.***> wrote:
@WeatherGod <https://github.com/weathergod> He only touched PyQt4 and
PyQt5.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9469 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-FST7Y7DjkARr2IcXwfHJEVwELB6ks5svQz9gaJpZM4P9O8E>
.
|
|
@WeatherGod This code is specific for pyqt(4/5) there are other similar function to check the version numbers of pyside(1/2) |
|
Ah, I didn't see the context of the function this change was in. |
dopplershift
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the correct versions shown.
See #9040 for details.
PR Summary
The PyQt versions shown when building was referring to the Qt library (C-library) and was not reflecting the used PyQt version which sometimes is different. This corrects this inconsistency (but shouldn't matter, build wise).