Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate pyplot.axes with an Axes argument #9968

Merged
merged 1 commit into from Dec 13, 2017

Conversation

timhoffm
Copy link
Member

Implements #9940

@@ -8,7 +8,7 @@
It also illustrates colorbar tick labelling with a multiplier.
"""

from matplotlib.pyplot import figure, show, axes, sci
from matplotlib.pyplot import figure, show, sca, sci
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only compalint is that I don't think we should be encouraging pyplot in the examples.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mildly agreed. But that's for another discussion. This one is about the pyplot.axes() API, so I just adapt the existing pyplot examples.

Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but going to let someone else approve it before merging since I missed the discussion.

@tacaswell tacaswell merged commit 1d1d23e into matplotlib:master Dec 13, 2017
@QuLogic QuLogic added this to the v2.2 milestone Dec 13, 2017
@timhoffm timhoffm deleted the deprecate-pyplot.axes-ax branch December 13, 2017 19:28
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants