Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scatter_piecharts example #9998

Merged
merged 1 commit into from
Dec 14, 2017
Merged

Fix scatter_piecharts example #9998

merged 1 commit into from
Dec 14, 2017

Conversation

timhoffm
Copy link
Member

Fixes #9185

@jklymak
Copy link
Member

jklymak commented Dec 14, 2017

The size of the pies is much smaller...

https://4513-1385122-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/gallery/api/scatter_piecharts.html#sphx-glr-gallery-api-scatter-piecharts-py

@timhoffm
Copy link
Member Author

@jklymak The sizes in #9185 are increased for better display of the issue. The original pies are that small: https://matplotlib.org/examples/api/scatter_piecharts.html

@jklymak
Copy link
Member

jklymak commented Dec 14, 2017

Ah, OK, that makes sense. Sorry for the noise...

@dstansby dstansby added this to the v2.2 milestone Dec 14, 2017
dstansby
dstansby approved these changes Dec 14, 2017
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dstansby dstansby merged commit fb18b4e into matplotlib:master Dec 14, 2017
@timhoffm timhoffm deleted the fix-scatter-pychart branch December 17, 2017 16:36
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timhoffm @jklymak @dstansby @QuLogic