Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign-off workflow doesn't like hyphens in names #18

Closed
DMRobertson opened this issue Mar 23, 2023 · 2 comments · Fixed by #20
Closed

Sign-off workflow doesn't like hyphens in names #18

DMRobertson opened this issue Mar 23, 2023 · 2 comments · Fixed by #20

Comments

@DMRobertson
Copy link
Contributor

(Pretty sure my diagnosis is right, eyeballing the regex that the script uses)

See e.g. matrix-org/complement#622 (comment) for example
@hughns
Copy link
Member

hughns commented Mar 23, 2023 •
edited
Loading

It looks like it wouldn't allow a ' or diacritics more generally.

Perhaps replacing the [\w ]+ with [^<>]+ would suffice.

@Half-Shot
Copy link
Collaborator

Fixed in #20

@clokep clokep linked a pull request Apr 27, 2023 that will close this issue
Make sign-off regex more leniant #20
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sign-off regex more leniant matrix-org/backend-meta
3 participants
@Half-Shot @hughns @DMRobertson