Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty from in /messages as per MSC3567 #3298

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Handle empty from in /messages as per MSC3567 #3298

merged 1 commit into from
Jan 9, 2024

Conversation

devonh
Copy link
Collaborator

@devonh devonh commented Jan 9, 2024

No description provided.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (13c5173) 65.37% compared to head (c3636f8) 65.40%.

Files Patch % Lines
syncapi/routing/messages.go 66.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3298      +/-   ##
==========================================
+ Coverage   65.37%   65.40%   +0.02%     
==========================================
  Files         509      509              
  Lines       57471    57481      +10     
==========================================
+ Hits        37573    37593      +20     
+ Misses      16006    16000       -6     
+ Partials     3892     3888       -4     
Flag Coverage Δ
unittests 50.04% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devonh devonh marked this pull request as ready for review January 9, 2024 19:05
@devonh devonh requested a review from a team as a code owner January 9, 2024 19:05
@devonh devonh merged commit 57646d5 into main Jan 9, 2024
19 of 20 checks passed
@devonh devonh deleted the msc3567 branch January 9, 2024 19:06
@S7evinK S7evinK mentioned this pull request Jan 29, 2024
S7evinK added a commit that referenced this pull request Jan 29, 2024
x86 tests broke with #3298
(Not exactly the tests modified here, but
`TestMessageHistoryVisibility`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants