This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Crypto: Rework device list tracking logic #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 10, 2017 17:42
tmp commit
fix some issues
add a public method to get device tracking status
Update unit tests
manuroe
reviewed
May 11, 2017
| } | ||
|
|
||
| if (isUpdated) { | ||
| mCryptoStore.saveDeviceTrackingStatuses(deviceTrackingStatuses); |
There was a problem hiding this comment.
This needs to be tested on device. The risk is to overload the store IO.
There was a problem hiding this comment.
I tested on a device, it seems working properly.
| for (String userId : userIds) { | ||
| if (forceDownload) { | ||
| Integer trackingStatus = mCryptoStore.getDeviceTrackingStatus(userId, TRACKING_STATUS_UNDEFINED); | ||
| if (TRACKING_STATUS_UP_TO_DATE != trackingStatus) { |
There was a problem hiding this comment.
in case of forceDownload, we should do a download with no more checking.
add TRACKING_STATUS_UNREACHABLE_SERVER status to avoid retrying the "not ready to retry" server
ylecollen
pushed a commit
to element-hq/riot-android
that referenced
this pull request
May 11, 2017
…racking logic)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent to matrix-org/matrix-js-sdk#425.
Equivalent to matrix-org/matrix-js-sdk#431.