Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's remove the ' (IRC)' suffix entirely. #194

Closed
ara4n opened this issue Sep 27, 2016 · 11 comments
Closed

Let's remove the ' (IRC)' suffix entirely. #194

ara4n opened this issue Sep 27, 2016 · 11 comments
Labels
matrix.org-support Matrix.org specific problem possibly unrelated to the bridge

Comments

@ara4n
Copy link
Member

ara4n commented Sep 27, 2016

It just annoys people, and the mxid is good enough, until we have groups/profiles

@kegsay kegsay added the matrix.org-support Matrix.org specific problem possibly unrelated to the bridge label Sep 27, 2016
@kegsay
Copy link
Member

kegsay commented Oct 6, 2016

What's the deal on this? We have 248823 @freenode_ users on the bridge database. I can write a script to rename them all to non-(IRC). I can update the config so subsequent users won't have (IRC). We're currently blocked on Synapse not sucking?

@ara4n
Copy link
Member Author

ara4n commented Oct 6, 2016

let's just fix the config for now for new users. if we can also update current ones when they next speak, that will probably help too.

@kegsay
Copy link
Member

kegsay commented Oct 14, 2016

This has been mentioned again, so assigning someone so this doesn't get lost.

I'd rather we didn't have to add code to the bridge to migrate users to the new display name style (like you propose when they "next speak"), as that will inevitably bitrot. I'd much rather do a config change + one time script to enumerate existing users, but I'm concerned that Synapse won't be up to the task of updating that many users. We can't really heavily rate limit this because there's too many of them, 1 per 10s would take 28.8 days to adjust. 1 per second would take 2.88 days which may be good enough?

@kegsay kegsay self-assigned this Oct 14, 2016
@kegsay
Copy link
Member

kegsay commented Dec 20, 2016

This has been mitigated because Riot removes " (IRC)" when tab-completing now. We still need to update the names, but the urgency is much less now.

@kegsay kegsay removed their assignment Dec 20, 2016
@Croydon
Copy link

Croydon commented Feb 22, 2017

Couldn't that be confusing when when there is one Matrix user and one IRC user with the same nickname/display name and both without profil picture? The only way to distinguish them would be a look on their user information.

On the other hand this (IRC) indeed annoys myself a bit. So not sure what to think about removing it all together.

@kegsay
Copy link
Member

kegsay commented Feb 23, 2017

@Croydon yes this was why the suffixes were originally added. Really the complete solution is to implement https://github.com/matrix-org/matrix-doc/issues/646

@jcgruenhage
Copy link

@Croydon Well, if there are two users with the same displayname in one room, riot shows their complete MXID anyway, so that won't be more confusing I think.

@Half-Shot Half-Shot changed the title Let's remove ther ' (IRC)' suffix entirely. Let's remove the ' (IRC)' suffix entirely. Aug 24, 2018
@Half-Shot
Copy link
Contributor

This has been fixed in the bridge. There is a bug internally for removing the suffixes from existing users.

@HackerFoo
Copy link

Is there a script to remove the suffix from existing databases? If so, could it be posted or linked here?

@flackr
Copy link

flackr commented Sep 16, 2019

Is it possible after changing the displayName on my bridge to purge the current users and have them recreated?

@reuben
Copy link

reuben commented Sep 24, 2019

Was this applied to the bridges run by Matrix? While connected to the Mozilla bridge via Riot I'm still seeing ' (IRC)' suffixes on all users, and autocomplete doesn't let me edit the names afterwards, so I have to type nicknames by hand which gets boring pretty quickly.

tadzik added a commit that referenced this issue May 18, 2022
This was decided and implemented on matrix.org long ago (with one
exception), but is still an unnecessary default.

See #194 (comment)
tadzik added a commit that referenced this issue May 18, 2022
This was decided and implemented on matrix.org long ago (with one
exception), but is still an unnecessary default.

See #194 (comment)
tadzik added a commit that referenced this issue Jul 28, 2022
* Remove (IRC) as a default suffix for displayNames

This was decided and implemented on matrix.org long ago (with one
exception), but is still an unnecessary default.

See #194 (comment)

* Add changelog for #1567

* Appease the changelog linter

Co-authored-by: Tadeusz Sośnierz <tadeusz@sosnierz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
matrix.org-support Matrix.org specific problem possibly unrelated to the bridge
Projects
None yet
Development

No branches or pull requests

8 participants