allow configuring debugApi host address #1546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Signed-off-by: f0x github@cthu.lu |
jaller94
reviewed
Mar 16, 2022
| @@ -84,6 +84,8 @@ properties: | |||
| type: "boolean" | |||
| port: | |||
| type: "integer" | |||
| host: | |||
| type: "string" | |||
| required: ["enabled", "port"] | |||
There was a problem hiding this comment.
The JS code currently expects host to always be defined.
For that to be the case it would need to be added to this array.
However, I'd prefer it if bridge admins aren't required to update their config.
There was a problem hiding this comment.
not defining host in config will keep the variable undefined, passing it around just fine? and thus keeping with the current behavior
jaller94
suggested changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #1545