Prevent low-risk SQL injection from roomId values when entered into the config #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 26, 2022 11:04
Half-Shot
changed the title
Half-Shot
approved these changes
Sep 26, 2022
Half-Shot
added a commit
that referenced
this pull request
Sep 26, 2022
…he config (#1619) * Prevent SQL injection from roomId values when checking room visibility * Add newsfile * Update newsfile * Update 1619.bugfix Co-authored-by: Will Hunt <will@half-shot.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents low-risk SQL injection from roomId values when checking room visibility.
This fixes a hard to exploit SQL injection vector.
To abuse this, an attacker needs to be able to set malicious Matrix IDs in the room mappings.