Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Node 19 #1646

Merged
merged 5 commits into from Dec 5, 2022
Merged

Support Node 19 #1646

merged 5 commits into from Dec 5, 2022

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Nov 10, 2022 •
edited

While waiting on upstream support for turt2live/matrix-bot-sdk#278

@Half-Shot Half-Shot requested a review from a team as a code owner November 10, 2022 10:34
jaller94
jaller94 approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jaller94
Copy link
Contributor

Travis did note on the linked PR that there are more incompatibilities in ´matrix-bot-sdk` with NodeJS 19.
So far I don't know if these impact the IRC bridge.

turt2live/matrix-bot-sdk#278 (review)

@Half-Shot
Copy link
Contributor Author

Travis did note on the linked PR that there are more incompatibilities in ´matrix-bot-sdk` with NodeJS 19.

I think that's not being supported rather than explicit incompatibilities, but noted.

@Half-Shot Half-Shot merged commit 0575c17 into develop Dec 5, 2022
@Half-Shot Half-Shot deleted the hs/node-19-compat branch December 5, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Half-Shot @jaller94